Closed
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: runcom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Member
Author
|
holding caues waiting on #442 /hold |
openshift-ci-robot
added
size/XXL
runcom
force-pushed
the
add-sync-status-tests
branch
2 times, most recently
from
f7e19f9 to
1c9501f
Compare
Fix a bug reported in openshift#406 (comment) where we weren't properly resetting the failing status. Signed-off-by: Antonio Murdaca <runcom@linux.com>
runcom
force-pushed
the
add-sync-status-tests
branch
from
1c9501f to
66b3ac7
Compare
Specifically, add a test to verify that we're clearing out the failing condition on subsequent sync operations (covering a bug reported here openshift#406 (comment)) Signed-off-by: Antonio Murdaca <runcom@linux.com>
runcom
force-pushed
the
add-sync-status-tests
branch
from
66b3ac7 to
9d0dd24
Compare
Signed-off-by: Antonio Murdaca <runcom@linux.com>
runcom
force-pushed
the
add-sync-status-tests
branch
from
9d0dd24 to
ac3eb7f
Compare
Member
Author
|
please take a look at ac3eb7f and identify other cases if you can as well |
Member
Author
|
those units are too important actually, the code added is just in testing anyway. Adding this to #442 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
This PR builds on #442 so let's hold until that merges.
The sync status is one of the most important thing we need NOT to regress on.
What the last commit really does is setting up a way to easily add more unit tests for the sync calls to avoid regression. I've modified the test in #442 to use the new way and added 2 other smoke tests. The aim is to add even more to cover the majority of the cases. (if not all)
For now, just review the last commit until #442 merges
- How to verify it
Run the unit tests
- Description for the changelog